Repository navigation
Conversation
The pattern came from the Go code of kntest, where `\d` sat in a raw string. When #230 moved the kubetest2 call into bash, it became `\\d` inside single quotes, which reaches the Go regexp as a literal backslash. The pattern never matches "only 2 nodes out of 3 have registered", so kubetest2 never retries that error in the next region.
GKE can fail a cluster create with a server-side error after it ran for a while: canonicalCode: CanonicalCodeValueValuesEnum(INTERNAL, 14) message: 'Failed to create cluster' None of the retry patterns match it, so the job fails before any test runs. On 2026-10-27 this failed two jobs of knative-extensions/eventing-kafka-broker#4830 in us-east1 after 26 minutes, while seven other jobs started at the same time got clusters. Match the INTERNAL code, so kubetest2 deletes the failed cluster and tries the next region. The pattern has no comma, because kubetest2 splits the flag on commas.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
approved
Contributor
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kubetest2 retries a failed GKE cluster create in the next region only when the error matches
--retryable-error-patterns. Two fixes to that list:\dsat in a raw string. When Deprecate calling kubetest2 via kntest #230 moved the call into bash, it became\\dinside single quotes, which reaches the Go regexp as a literal backslash.canonicalCode: CanonicalCodeValueValuesEnum(INTERNAL, 14)andFailed to create cluster, which no pattern matches. Now it does, so kubetest2 deletes the failed cluster and tries us-central1.Seen on knative-extensions/eventing-kafka-broker#4830, where two jobs failed this way in us-east1 after 26 minutes, while seven other jobs started at the same time got clusters:
I checked both patterns with Go's
regexpagainst the flag value as bash passes it, and the INTERNAL one against the error string from the job above. kubetest2 splits the flag on commas, so the new pattern has none.cc @dsimansk